winapi-rs icon indicating copy to clipboard operation
winapi-rs copied to clipboard

Add isolation aware support to 0.2 branch

Open Osspial opened this issue 7 years ago • 4 comments

Adds macros to the kernel32, user32, comctl32, and comdlg32 libraries on the 0.2 branch to create isolation-aware functions. These are exposed as macros rather than as modules in the respective crates because isolation aware mode requires library-local data to be created in order to hold the activation context, and macros let the data be inlined into the using library. Right now, this doesn't handle cleaning up the created activation contexts, though I'm not entirely sure how to expose that functionality.

This was developed against the 0.2 branch because I needed to use it for my own crate, but porting it to 0.3 should just be a matter of moving the isolation_aware.rs files and changing a few imports.

Osspial avatar Mar 28 '17 01:03 Osspial

Would close issue #399

Osspial avatar Mar 28 '17 01:03 Osspial

I believe that @retep998 is only accepting PRs to the active development branch dev, so using the 0.3 API. Could you rebase this on that branch instead? You can set the merge branch to dev by hitting the Edit button next to the PR title.

Susurrus avatar May 12 '17 14:05 Susurrus

Reviewing this PR is being postponed until winapi 0.3 is finally published, at which point I will investigate things like these.

retep998 avatar May 12 '17 20:05 retep998

0.3 is released right? Surprisingly, I don't see conflicts according to github

So this is review-able? AIUI, there's a lack of reviewers for winapi atm, so maybe it'd be easier to get this merged in chunks as separate stand alone PRs?

nico-abram avatar Nov 27 '20 16:11 nico-abram