Peter Atashian comments

Results 131 comments of


                                            Peter Atashian

c_void has incorrect layout in no_std

Does the layout matter?

Migrate wincodec APIs

You uh.... messed up the history of your PR.

Wrong type of SE_RESTORE_NAME

Unfortunately Rust does not offer any good way to express wide string literals. Hopefully in 0.4 I'll figure out a good way to do this, potentially a procedural macro. In...

CONTEXT should be aligned to 16-byte boundary

This will be fixed in winapi 0.4 when the minimum Rust version is bumped to support `#[repr(align(N))]`

GetCurrentProcessToken and others are commented out

It's just because nobody ever actually filled them out. They were just added there as comments to indicate where they would go.

Use core c_void type and remove need for libc

This change will be done in 0.4 when the MSRV is bumped

Let `#define`d functions on 32-bit have same signatures as on 64-bit.

This is a breaking change that will have to be postponed until the next major version.

Let `#define`d functions on 32-bit have same signatures as on 64-bit.

No, because that is not what `master` is for (and also I can change what branch a PR is against anyway, no need to recreate PRs).

bindings for dbgeng.h and wdbgexts.h

It's not the variadic FFI function, but rather the macro itself. Macros have had a lot of subtle changes over the versions, so it's easy to run into failure cases.

Wrong ABI used for small C++ classes on Linux.

>Perhaps the rule should be that all non-Copy types are passed by-pointer? Please no. This would wreak so much havoc when ABIs mysteriously change due to the addition or removal...