angular-plugin icon indicating copy to clipboard operation
angular-plugin copied to clipboard

No standalone support for ReteModule

Open pandabits opened this issue 1 year ago • 4 comments

Describe the bug

Currently with Angular 17, its not possible to import ReteModule or RefDirective in a standalone component which is the default approach for Angular 17. When writing custom components, this is an issue and can only be solved by implementing a module with the classic approach.

Example to reproduce

No response

How to reproduce

  • Create a custom node component
  • Mark as standalone
  • Try to use refComponent directive
  • Import not possible for ReteModule or RefDirective cause its not standalone

Expected behavior

I can import ReteModule / RefDirective in order to use standalone components

Dependencies

+-- @angular-devkit/[email protected]
+-- @angular-eslint/[email protected]
+-- @angular-eslint/[email protected] +-- @angular-eslint/[email protected]
+-- @angular-eslint/[email protected]
+-- @angular-eslint/[email protected]
+-- @angular/[email protected]
+-- @angular/[email protected]
+-- @angular/[email protected]
+-- @angular/[email protected]
+-- @angular/[email protected]
+-- @angular/[email protected]
+-- @angular/[email protected]
+-- @angular/[email protected] +-- @angular/[email protected] +-- @angular/[email protected] +-- @angular/[email protected] +-- @angular/[email protected] +-- @angular/[email protected] +-- @auth0/[email protected] +-- @iharbeck/[email protected] +-- @microsoft/[email protected] +-- @rxweb/[email protected] +-- @types/[email protected] +-- @types/[email protected] +-- @types/[email protected] +-- @types/[email protected] +-- @types/[email protected] +-- @types/[email protected] +-- @types/[email protected] +-- @typescript-eslint/[email protected] +-- @typescript-eslint/[email protected] +-- @typescript-eslint/[email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] +-- [email protected] `-- [email protected]

Platform

No response

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

pandabits avatar Apr 24 '24 09:04 pandabits

+1

adlion avatar Nov 23 '24 21:11 adlion

partially resolved by https://github.com/retejs/angular-plugin/pull/135

This is a compromise solution: with support for version 19, Standalone mode is now default, so the build for this version specifically supports only Standalone mode.

Ni55aN avatar Dec 30 '24 15:12 Ni55aN

@Ni55aN the changes in #135 are incomplete as only some components have their imports: [...] patched. E.g. ContextMenuItemComponent throws about a missing ngIf since it doesn't import the CommonModule (the main context menu works since this has a patch). Same goes for the classic components (only NodeComponent is patched), PinComponent, MiniViewportComponent, MiniNodeComponent.

ibauersachs avatar Jan 03 '25 14:01 ibauersachs

@ibauersachs fixed

Ni55aN avatar Jan 04 '25 12:01 Ni55aN

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

rete-js[bot] avatar Apr 17 '25 02:04 rete-js[bot]

This issue was closed because it has been stalled for 10 days with no activity.

rete-js[bot] avatar May 08 '25 02:05 rete-js[bot]