hllpp icon indicating copy to clipboard operation
hllpp copied to clipboard

Question: What's the reason for using murmur hash?

Open gaurav-gogia opened this issue 2 years ago • 1 comments

Hey,

I just wanted to ask the reason for using murmur hash here instead of some other cryptographically strong hash like SHA3 or BLAKE3 or something? Wouldn't using murmur hash affect accuracy of results? I understand that you are optimising for memory instead of CPU so I feel using a cryptographically secure hash will still stay aligned with your goals.

Please advise if my thoughts are correct here. Thanks

gaurav-gogia avatar Jul 13 '23 18:07 gaurav-gogia

Cryptographically secure hashes are slower. Since this is not a cryptographic application, I went with murmur, which was a good combination of speed and uniformity.

Originally the hash was configurable via the hash.Hash interface, but that was too slow.

muirdm avatar Aug 19 '23 20:08 muirdm