Mathieu Guindon

Results 111 comments of Mathieu Guindon

@Zomis what's the domain/subdomain of that url again? > `codereview.stackexchange.com` hmm maybe I need to fine-tune the way I word specs...

Thanks! I've indeed pretty much abandoned this repository (got something else in mind, next blog post will touch on it!). Funny you poke me here & now: I was refactoring...

FYI [Rubberduck](https://github.com/rubberduck-vba/Rubberduck) is now using a much more robust grammar now, but there are limitations that we deal with... using additional grammars (and some C# code, too): - [Rubberduck.Parsing/Grammar/VBALexer.g4](https://github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.Parsing/Grammar/VBALexer.g4) -...

> or adding a group by module option for the old behaviour and make group by location do the Rubberduck way. I like that 👍

Ref. #1585, #2382, #4430; note implicit conversions *to* `Variant` should be ignored, to avoid flagging arguments to the many built-in functions that take `Variant` parameters.

I'm not sure there's such a thing as as *dumb implementation* of this refactoring, but I agree it's a *very* complex one to tackle, with a ton of traps along...

Oh, also - the refactoring needs to be able to work off a `QualifiedSelection`, so that we can invoke it programmatically, say, from a hypothetical quick-fix that suggests extracting a...

The dialog seems to have disappeared, but this is what it looked like in v1.4.3: ![687474703a2f2f692e737461636b2e696d6775722e636f6d2f46685577742e706e67](https://user-images.githubusercontent.com/5751684/30113417-a9fc3534-92e2-11e7-9387-bb46380f0d38.png)

As for variables in the original method, as long as the refactoring doesn't leave the code uncompilable, it's fine: a variable that's declared but never assigned or referred to will...