Andriy Redko

Results 791 comments of Andriy Redko

> Assuming the Java policy parser is replaced, would it be sufficient to do some sanity testing of the distribution with a JDK-24 runtime? Thanks @andrross absolutely sufficient but we...

> Hi @reta a bit confused here. Even if we update CI to have JDK24, isnt libs.versions.toml also needs to be updated? But then Core will bundle 24 instead of...

Waiting for this guy https://github.com/opensearch-project/OpenSearch/pull/17942, since Gradle 8.13 does not support JDK-24 :D

[Catch All Triage - [1](https://github.com/dblock), [2](https://github.com/reta), [3](https://github.com/amistrn), [4](https://github.com/krisfreedain)]

> @rursprung I would distinguish that this is purely the JSR305 annotations (ie. javax.annotation.Nullable & co) not the findbugs analysis tool. As it's only annotation interfaces and contains no logic,...

> What's the benefit of returning to this approach, given that you got it to work without? Thanks for looking @tomakehurst , I think functionally-wise there are no benefits really,...

> I'd quite like to get rid of the dependence on servlet contexts completely in WM. Seems pointless to still be coupled to it in 2024, and it makes it...

> If an unmounted virtual thread using RealScopedSpan is next line for the lock, but all carriers are currently occupied by pinned VTs in RealSpan.finish, the application will deadlock: The...

The reasoning behind keeping `synchronized` are provided here https://github.com/openzipkin/brave/issues/1426 (plus, the recent updates on progress of the Java monitors https://mail.openjdk.org/pipermail/loom-dev/2024-May/006632.html , you may be interested in trying your examples with...

> Here, the latter is true, this was a real-world application that deadlocked in production. This part certainly deserves a fix, I will try to take a look shortly