Andriy Redko
Andriy Redko
Thanks for the PR, @timothyjward , I believe we should take a step back and think about what we would like to implement first. So we want to provide the...
@deki wondering if you have time to check this one out, thank you!
> Thus, I think the better fix would be to pass a flag into LazyDataSource to allow flipping to URLDataSource if the CID isn't present as a direct attachment. @dkulp...
> The main issue is that SOAP w/ Attachments doesn't have that limitation. Thus, applying that limitation in AttachmentUtils is not the right place unless an extra flag is passed...
@dkulp relied on `isXOPPackage()` flag of the `AttachmentUnmarshaller` to distinguish xop / non-xop cases, what do you think of it? Thank you!
@dblevins do you mind if I close this one? TCK tests are all passing now, thanks!
Thanks @dtsybulka, LGTM, @ashakirin anything you want to add / comment / change?
@coheigea no objections, won't merge without your and @ashakirin approvals, thanks!
Sorry @andymc12, I haven't had time to review this PR yet (not forgotten), will do that shortly. The integration builds are not triggering right now since the CI server has...
> > > @reta I think so - what do I need to change? thanks @coheigea , there are instructions on wiki: https://cwiki.apache.org/confluence/display/INFRA/Kicking+off+a+Jenkins+build+with+a+GitHub+PR (please feel free to ping me in...