Andriy Redko

Results 793 comments of Andriy Redko

Thanks a lot for the review @hlteoh37 , I believe I addressed or/and answered all your comments, please let me know if I missed something

Thanks @dannycranmer , I think I went through all your comments, thanks a lot, really appreciate it.

Thanks a lot for review @dannycranmer > @reta The PR looks good to me minus the Mockito comment. However I have questions over the approach here. We are adding a...

@dannycranmer would appreciate if you could take a look, thank you

> I am reluctant to introduce a new Sink API based on the internal implementation unless there is a really good/semantic reason. Thanks @dannycranmer , I understand your concerns. I...

Covered by https://github.com/apache/cxf/pull/1894

From my perspective, I _would not_ label the `job-sheduler` plugin as a core one: - by and large, it has nothing to do with bare search or indexing - in...

@harshavamsi what is preventing us to use the `opensearch-java` as intended, using typed request and response models? (I think that what you meant in approach #2).

> What were you think about doing in https://github.com/opensearch-project/spring-data-opensearch/issues/19? Were you going to pull in the request/response types from `opensearch-java`? Yes, the plan going forward is to recommend `opensearch-java` as...