reswqa
reswqa
We should include it as flink has nightly ci that check jdk17 build also. Otherwise this pr will broke ci pipeline.
> I suggest we leave the fix as is, with the method you added, and not do a large amount of 1.19 -1.18 back ports. WDYT? It looks like we...
Oops, I just found that the newly introduce method in sql gateway context breaks japicmp's compatibility check. https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=59754&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=13638 I filed a PR hoping to fix it. https://github.com/apache/flink/pull/24831
Could you rebase on the latest master branch for safety. I will merge this after AZP passed.
Thanks @X-czh, I think we only need two commits. One for the implementation and one for documentation.
Not to block this, just curious do you know why FLINK-34954 affects performance?
Let's build the doc to see if it was fixed.
@kumar-mallikarjuna Thanks for the rebase, could you squash these to some meaningful commits? I will merge this PR then.
Sorry for the delay, I shall merge this after CI green(A few days ago, there was a problem with CI pipelline, which has been in the `UNKNOWN` state. I rebase...
@lsyldliu Would you mind checking this fix? Thanks!