restate icon indicating copy to clipboard operation
restate copied to clipboard

[CLI] Make CLI commands not fail if contextual queries fail

Open tillrohrmann opened this issue 2 months ago • 2 comments

Some CLI commands try to give users additional context for which they query additional information from the cluster. If this information is not strictly necessary to perform the operation, the CLI command should ideally not fail if the contextual query fails.

E.g. when trying to cancel/kill an invocation for which the user provides the invocation id, we shouldn't fail the command just because the find active invocations query timed out (note that this query is necessary if the user did not specify the invocation id).

tillrohrmann avatar Oct 02 '25 16:10 tillrohrmann

We can perhaps even skip the invocation id query completely. This existed because in the past, we didn't have the feedback channel when sending cancel (it would always return 201 neverthless). Now cancel returns 404 when invocation not found, so we got the feedback channel.

slinkydeveloper avatar Oct 07 '25 09:10 slinkydeveloper

notes from @slinkydeveloper

there's 2 dimensions to this: if the user gave me the invocation id -> no query should run at all if the user gave me a query -> and it's auto accept -> i think it should be done in a streaming fashion

muhamadazmy avatar Oct 16 '25 07:10 muhamadazmy

@muhamadazmy, @slinkydeveloper has this issue been resolved with the --extra work?

tillrohrmann avatar Nov 17 '25 11:11 tillrohrmann

@tillrohrmann I don't believe the --extra work touches this use case described in this issue. The --extra work done here https://github.com/restatedev/restate/pull/3875/files only speed up the deployment describe and list commands.

I can pick this one up today

muhamadazmy avatar Nov 18 '25 09:11 muhamadazmy

Thanks for the update @muhamadazmy. I think this issue does not have to resolved for 1.6. So you can leave it be for the time being.

tillrohrmann avatar Nov 18 '25 09:11 tillrohrmann