restate icon indicating copy to clipboard operation
restate copied to clipboard
verified publisher icon restatedev

[OLD] Reset invocation

Open slinkydeveloper opened this issue 10 months ago • 5 comments

Fix #2890, depends on https://github.com/restatedev/restate/pull/2904

slinkydeveloper avatar Apr 22 '25 17:04 slinkydeveloper

E2E test https://github.com/restatedev/e2e/pull/377

slinkydeveloper avatar Apr 23 '25 10:04 slinkydeveloper

Followup PRs will be:

  • Replace admin API bifrost proposals with RPC client, to enable propagating errors back
  • https://github.com/restatedev/restate/issues/3197
  • Add knob to Kill child invocations when resetting an invocation
  • Revert state changes when resetting an invocation
  • Align Kill with Reset invocation (this https://github.com/restatedev/restate/issues/2890#issuecomment-2841575386)

slinkydeveloper avatar Apr 30 '25 13:04 slinkydeveloper

Will rebase this PR on https://github.com/restatedev/restate/pull/3227 when ready.

slinkydeveloper avatar May 06 '25 16:05 slinkydeveloper

After some internal conversations, we agreed on for now merging this feature without reverting state, and give it a try like this. This feature also needs to retain the old journals, something i'll do for https://github.com/restatedev/restate/issues/3347 primarily and then re-adapt this PR here. I'm gonna rebase few things, figure out retaining old journals, and then i'll ask another review for this PR.

slinkydeveloper avatar Jun 03 '25 14:06 slinkydeveloper

I rebased this PR on #3360, it also contains the changes from #3362 (1:1, so once that one is merged, it should disappear from this diff). This got a bit messy with the different branches :D For this feature specifically, only the last commit matters.

slinkydeveloper avatar Jun 05 '25 16:06 slinkydeveloper