restate icon indicating copy to clipboard operation
restate copied to clipboard

No-op to invocation status table v1 when table is empty on boot

Open slinkydeveloper opened this issue 1 year ago • 6 comments

Completely disable codepaths using invocation status v1 in InvocationStatusTable when the key space of invocation status v1 is empty. We can do so because in the next release, no one will write to the invocation status v1 key space anymore, so if the table is empty will remain empty for the rest of the execution.

We can probably add a check for that when initializing the PartitionStore.

slinkydeveloper avatar Oct 29 '24 08:10 slinkydeveloper

This is a followup of https://github.com/restatedev/restate/pull/2016

slinkydeveloper avatar Oct 29 '24 08:10 slinkydeveloper

/take

edmondop avatar Nov 27 '24 16:11 edmondop

@slinkydeveloper is this a release blocker for 1.2?

tillrohrmann avatar Feb 14 '25 08:02 tillrohrmann

It's not a blocker, it was just a perf optimization. we can ignore.

slinkydeveloper avatar Feb 14 '25 08:02 slinkydeveloper

@tillrohrmann i think we can close this, it's irrelevant at this point unless someone fixes it for 1.3 (which is due soon), as in 1.4 we remove this table once and for all.

slinkydeveloper avatar Mar 24 '25 08:03 slinkydeveloper

Opened a similar one for idempotency table https://github.com/restatedev/restate/issues/2983

slinkydeveloper avatar Mar 24 '25 08:03 slinkydeveloper

Done

slinkydeveloper avatar Sep 03 '25 08:09 slinkydeveloper