framework icon indicating copy to clipboard operation
framework copied to clipboard

TRestMesh node data members improved design

Open jgalan opened this issue 4 years ago • 0 comments

The TRestMesh coordinates, energy and group id data members would be better encapsulated into a single structure so that we define for example

struct MeshNode {
UInt_t GroupID;
Int_t X;
Int_t Y;
Int_t Z;
Double_t Energy;
}

Then, we would replace

    /// A vector storing the group ID of the corresponding nodes activated
    std::vector<Int_t> fNodeGroupID;
    /// A vector storing the X-dimension cell id
    std::vector<Int_t> fNodeX;
    /// A vector storing the Y-dimension cell id
    std::vector<Int_t> fNodeY;
    /// A vector storing the Z-dimension cell id
    std::vector<Int_t> fNodeZ;
    /// A vector storing the total energy inside the cell id
    std::vector<Double_t> fEnergy;

by

std::vector <MeshNode> fMeshNodes;

This issue was brought by @juanangp at PR #73

jgalan avatar Jun 21 '21 19:06 jgalan