framework icon indicating copy to clipboard operation
framework copied to clipboard

mpreal.h has been removed

Open raulena333 opened this issue 2 years ago • 4 comments

raulena333 Ok: 20

mpreal.h has been removed because it caused conflicts with some versions of MPFR libraries.

This compatibility issue seemed to be originated by the mpreal.h header present in the framework.

The mpreal.h is included inside the linux package libmpfrc++-dev

raulena333 avatar May 03 '23 11:05 raulena333

Hi @lobis, it would be better to include the library libmpfrc++-dev inside the docker. Because it creates problems when the mpfr-dev library does not match the same version as the hard coded header inside the framework.

It would be an issue to add that package to the docker?

jgalan avatar May 03 '23 13:05 jgalan

Hi @lobis, it would be better to include the library libmpfrc++-dev inside the docker. Because it creates problems when the mpfr-dev library does not match the same version as the hard coded header inside the framework.

It would be an issue to add that package to the docker?

It should not be a problem (I assume it's installed as apt-get install libmpfrc++-dev in Ubuntu).

However its been a while since I modify the docker image and perhaps something can break due to some other circumstances, so I wouldn't update the "main" tag (the one we use for CI) of the Docker image without testing.

In fact we should transition from using the docker images I published in my profile to using an official rest-for-physics image as stated in https://github.com/rest-for-physics/framework/pull/365. When I started working on it there were some problems I can't recall very well now and it got stuck, I can take a look this week and add this dependency, then update the CI image for all repositories.

I think from now on we should use https://github.com/rest-for-physics/rest-docker/issues to create requests / issues related to dependencies on the Docker image (I am assuming the official image will be hosted in this repository, after I fix the problems).

lobis avatar May 03 '23 13:05 lobis

It should not be a problem (I assume it's installed as apt-get install libmpfrc++-dev in Ubuntu).

Yes, it is installed this way.

It has been added in the recent docker update?

jgalan avatar May 08 '23 14:05 jgalan

It should not be a problem (I assume it's installed as apt-get install libmpfrc++-dev in Ubuntu).

Yes, it is installed this way.

It has been added in the recent docker update?

Yes it has been added, now we need to merge all PRs to update the image:

https://github.com/rest-for-physics/framework/issues/413

lobis avatar May 08 '23 14:05 lobis