resque-pool icon indicating copy to clipboard operation
resque-pool copied to clipboard

resque-pool 0.5.0 broke resque:work rake task

Open kovyrin opened this issue 9 years ago • 1 comments

Hey guys,

I'm not sure if that was intentional, but resque-pool 0.5.0 (specifically, this commit: 2f91e9114556cb75c73a7b05d3ebaebec7ae9304) changed the way shutdown? method works and now there is no way to run rake resque:work without resque pool - it just exits immediately upon exiting the main processing loop (since there are no parent pids registered by resque-pool).

Basically, this means that by simply including resque-pool in a Gemfile of a project one loses ability to use resque without executing the resque-pool command.

kovyrin avatar Jun 26 '15 19:06 kovyrin

Not intentional. It was meant to fix a problem with running resque-pool inside docker. I think that you should be able to temporarily workaround this by telling the Gemfile to require: nil so it doesn't get automatically loaded, and then explicitly require it from the rake task (resque:pool) or just use the command line bin/resque-pool.

A fix would be as simple as checking to see if either of the two pids have been set, and if neither have then default to normal behavior.

nevans avatar Jun 30 '15 15:06 nevans