resque-loner icon indicating copy to clipboard operation
resque-loner copied to clipboard

Resque::Helpers will be gone with no replacement in Resque 2.0.0.

Open kforsman opened this issue 10 years ago • 16 comments

Hi there, thanks for a great gem. I have started to see this warning in the logs (Resque::Helpers will be gone with no replacement in Resque 2.0.0.), looks like it stems from resque-loner. Any plans to make it compatible with Resque 2.0?

kforsman avatar Sep 23 '13 05:09 kforsman

+1

kaluznyo avatar Oct 07 '13 10:10 kaluznyo

+1

sahin avatar Oct 11 '13 21:10 sahin

+1

gthiruva avatar Nov 07 '13 22:11 gthiruva

+1

hlascelles avatar Nov 14 '13 16:11 hlascelles

+1

apsoto avatar Nov 25 '13 17:11 apsoto

+1

matteomelani avatar Nov 27 '13 16:11 matteomelani

I began to fix this at https://github.com/teeparham/resque-loner & ended up re-writing it as a separate gem called resque_solo. The plugin's job name is still Resque::Plugins::UniqueJob so all you need to do to swap back & forth is change the gem. It removes the Resque::Helpers warnings for resque 1.25.

https://github.com/neighborland/resque_solo

teeparham avatar Dec 17 '13 06:12 teeparham

When you say rewrite does that mean it's not a simple fork plus patch? Loner has been stable for so long 'rewrite' concerns me.

apsoto avatar Dec 18 '13 05:12 apsoto

@apsoto Re: resque_solo: The tests are basically the same. I used fakeredis instead of an actual redis server in test. I re-structured the internal classes. I started with a blank project & copied many of the tests and much of the code. We're running it in production, if that helps.

teeparham avatar Dec 18 '13 05:12 teeparham

+1

pangkalizer avatar Jun 04 '14 01:06 pangkalizer

@teeparham - neat, thanks :+1: for effort, will give it a try

rwojsznis avatar Jun 27 '14 07:06 rwojsznis

+1

faheemmughal avatar Jul 30 '14 14:07 faheemmughal

+1

klippx avatar Aug 04 '14 08:08 klippx

@teeparham I love the addition of the lock_after_execution_period -- exactly what I was looking for. Thank you!

tkalimov avatar Oct 07 '14 14:10 tkalimov

+1

nickmalcolm avatar Feb 11 '15 21:02 nickmalcolm

+1

idlecool avatar Mar 19 '16 00:03 idlecool