resque-loner
resque-loner copied to clipboard
Resque::Helpers will be gone with no replacement in Resque 2.0.0.
Hi there, thanks for a great gem. I have started to see this warning in the logs (Resque::Helpers will be gone with no replacement in Resque 2.0.0.), looks like it stems from resque-loner. Any plans to make it compatible with Resque 2.0?
+1
+1
+1
+1
+1
+1
I began to fix this at https://github.com/teeparham/resque-loner & ended up re-writing it as a separate gem called resque_solo
. The plugin's job name is still Resque::Plugins::UniqueJob
so all you need to do to swap back & forth is change the gem. It removes the Resque::Helpers
warnings for resque 1.25.
https://github.com/neighborland/resque_solo
When you say rewrite does that mean it's not a simple fork plus patch? Loner has been stable for so long 'rewrite' concerns me.
@apsoto Re: resque_solo: The tests are basically the same. I used fakeredis instead of an actual redis server in test. I re-structured the internal classes. I started with a blank project & copied many of the tests and much of the code. We're running it in production, if that helps.
+1
@teeparham - neat, thanks :+1: for effort, will give it a try
+1
+1
@teeparham I love the addition of the lock_after_execution_period -- exactly what I was looking for. Thank you!
+1
+1