chore(deps): bump braces from 3.0.2 to 3.0.3 in /desktop-app/release/app
Bumps braces from 3.0.2 to 3.0.3.
Commits
74b2db23.0.388f1429update eslint. lint, fix unit tests.415d660Snyk js braces 6838727 (#40)190510ffix tests, skip 1 test in test/braces.expand716eb9freadme bumpa5851e5Merge pull request #37 from coderaiser/fix/vulnerability2092bd1feature: braces: add maxSymbols (https://github.com/micromatch/braces/issues/...9f5b4cffix: vulnerability (https://security.snyk.io/vuln/SNYK-JS-BRACES-6838727)98414f9remove funding file665ab5dupdate keepEscaping doc (#27)- Additional commits viewable in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.
Note : The best way to show this particular feature is to use Firefox browser.
Hello, I'm new to contributing to open source, is this something I can work on?
Yes
Hey @Phrygan are you still working on this? Do you mind if I take a crack at it?
Go ahead, I never got the opportunity to work on it.
Further research is necessary but it looks like the PointerPressed event isn't compatible in the title bar drag area.
Further research is necessary but it looks like the
PointerPressedevent isn't compatible in the title bar drag area.
Yes it's true. Today I spent the whole day making this issue, but I still couldn’t understand why the event wasn’t triggered. I'll look into the issue tomorrow
In General, I think I understand why the PointerPressed event does not work on the title bar drag area, the fact is that this area belongs to the non-client area of the window, which means it is processed in a special way. I found a class in the documentation that should help solve the click tracking problem. Here is an excerpt from the documentation
When you add interactive content in the title bar area, you need to use the InputNonClientPointerSource class to specify areas where input is passed through to the interactive control, rather than handled by the title bar
Here are some links where I found information https://learn.microsoft.com/en-us/windows/win32/gdi/nonclient-area
https://learn.microsoft.com/en-us/windows/apps/develop/title-bar
https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.input.inputnonclientpointersource.pointerpressed?view=windows-app-sdk-1.5#microsoft-ui-input-inputnonclientpointersource-pointerpressed
I don’t claim to be telling the truth, maybe I don’t understand how the whole project works