responsively-app icon indicating copy to clipboard operation
responsively-app copied to clipboard

Disable Mirroring not working for redirections

Open palash018 opened this issue 2 years ago • 7 comments

🐞 bug report

✍️ Description

Disable mirroring is not working well, On clicking buttons which doesn't redirect it works but when redirected links are clicked other device windows also redirects.

🔬 Minimal Reproduction

Follow Development setup from readme using yarn, and click on disable mirroring after running app. Click on about in the Google search bar in the disabled device.

🌍 Your Environment

Windows 11 x64 yarn 1.22.19

🔥 Exception or Error or Screenshot

https://github.com/responsively-org/responsively-app/assets/109908523/2ea2f846-d837-4978-a26c-0f12cc2735ca

palash018 avatar Sep 22 '23 11:09 palash018

Can i get this assigned?

palash018 avatar Sep 22 '23 11:09 palash018

@palash018 We stopped assigning issues, please go ahead and let us know if you get any questions along the way. .

manojVivek avatar Sep 22 '23 12:09 manojVivek

@manojVivek were you able to reproduce this issue?

palash018 avatar Sep 22 '23 13:09 palash018

It could be because, when you click on a link within a device, it alters the main URL, causing each device to change. However, there exists only one primary URL that is employed across all devices, even if you click on the event mirroring button.

haseeb196 avatar Sep 23 '23 22:09 haseeb196

@haseeb196 yeah i checked it out. This seems to be how it's working , are you trying to solve this?

palash018 avatar Oct 08 '23 06:10 palash018

Hi I noticed this issue as well check some factors. don't you think this problem related to this function that does not work correctly?

onst toggleEventMirroring = async () => { if (webview == null) { console.log('webview == null'); return; } try { await webview.executeJavaScript( if(window.___browserSync___){ window.___browserSync___.socket.${ eventMirroringOff ? 'open' : 'close' }() } true );

  setEventMirroringOff((pre) => !pre);
} catch (error) {
  // eslint-disable-next-line no-console
  console.error('Error while toggleing event mirroring', error);
}

}; may it be related to browserSync or electron?

negar-75 avatar Oct 30 '23 12:10 negar-75

.github/workflows/azure-webapps-node.yml

Mehranmj4 avatar Dec 08 '23 22:12 Mehranmj4