responsively-app
responsively-app copied to clipboard
responsively-org
Zoom in/out of devices on trackpad pinch gesture in the preview area
Hi @manojVivek, I would like to work on this issue. Please assign it to me.
HI @manojVivek i would like to take up this issue if possible. Assign it to me.
@dgbkn Please go for it! We stopped doing user assignments for the issues.
@manojVivek Could you please elaborate the issue? It will be very beneficial while resolving the issue.
Hi @manojVivek, I would like to work on this issue. Please assign it to me.
@manojVivek we can not directly use zoom pan pinch lib here due to the fact that lib does not support webview tag. We need to write its logic manually.
@Alok-Singh-ops Thanks for exploring that.
But we don't actually need that event handler on the webview, we just have to add it to the preview area enclosing the webview.
@manojVivek yes i get it. i Even tried to do using lib such as zoom pan but I guess the library just does not support webview
Hm, I'm not certain why webview would affect anything here.
As we don't need to interact with the webview at all in this, we just have to watch for the events on the preview container and update the zoom level in the redux state.
@manojVivek Gotcha. By this entire preview section will be zoomed in/zoomed out
By this entire preview section will be zoomed in/zoomed out
Just clarifying, not the entire section, just the devices will be zoomed by the zoomFactor state value.
From what I can tell there needs to be some sort of onWheel or onScroll event to trigger the zoomFactor update but it doesnt seem to respond to any of those events (also doesn't respond to onClick) I think something about the webview is preventing the div from detecting events
Edit: When I expand the div to be larger than the webview actions outside of the webview are detected so it is something about the webview not being able to detect the pinch to zoom
Hi @manojVivek, I would like to work on this issue. Please assign it to me.
Hey @manojVivek, I went ahead and created a PR for this (#1196) since it looks like it hasn't been addressed yet!
@manojVivek explain me the functionality you are working on ?? which issue is this assign it to me
Hello everyone, do we have any updates regarding this issue? If not, I'm more than willing to lend a hand and contribute. Thanks!
