Lei Zhang (Harry)

Results 151 comments of Lei Zhang (Harry)

@wonderflow That being said, it's indeed necessary to automatically add labels to OAM workloads and traits. Could you please raise a separate issue for this? I'd guess https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/ could be...

You need to create a SidecarSet trait: https://github.com/openkruise/kruise/blob/master/docs/tutorial/sidecarset.md

@wenxinnnnn The patch trait PR is WIP: https://github.com/crossplane/oam-kubernetes-runtime/pull/134 Btw, `ContainerizedWorkload` will propagate its labels/annotations to Pods, see: https://github.com/crossplane/oam-kubernetes-runtime/pull/166. So the only thing you need to do is directly define a...

The `workload` hierarchy on top of `spec` seems useless. Can we avoid that? For example: ```yaml apiVersion: core.oam.dev/v1alpha2 kind: Component metadata: name: frontend spec: workload: type: Server spec: image: nginx...

This also makes it right that `workload` section is a template of workload instances.

@JingbenShi668 Please check the existing examples: https://github.com/crossplane/oam-kubernetes-runtime/tree/master/examples. Note that we now decide to keep this repo as is and focus on implement all features in KubeVela side, please check the...

We normally consider ConfigMap/Secret (i.e. the carrier of external data) not part of the application definition (i.e. model with components). Though if that's the preference, using CUE or Helm to...

That network scope should be able to be referenced by multiple components. Btw, this issue is more suitable to spec repo.

@ryanzhang-oss These labels are all component's info, not workload, I've updated the label key and example.