reshke
reshke
Will try to take a look soon
Hi! Thanks you for your interest in this. > Thanks for raising this ticket, but it isn't super clear the motivation and more importantly how you will use the new...
Hi! some initial review: 1) Patch miss tab-completion for DYNAMIC feature. 2) When trying to modify dynamic table ``` reshke=# insert into td values(1, 1); ERROR: cannot change materialized view...
> I'm not planing to copy lot's of duplicated codes from matview Im not suggesting this, the thing i propose is to change CREATE DYNAMIC TABLE syntax to CREATE DYNAMIC...
UPD: cherry-pick [a6fdc27246e46bf3b72d43420c1454a37e68e273](https://github.com/greenplum-db/gpdb-archive/commit/a6fdc27246e46bf3b72d43420c1454a37e68e273#diff-2966b4855c050bfab2734c3987a74097c0c38473a042d9d2210b601554839b16) from gp7 to fix incorrect regression test results
> Thanks for your Merge Request. I think We'd better revert the last commit which have been merged and squash the last two commit ([refac](https://github.com/cloudberrydb/cloudberrydb/pull/611/commits/5c3f686ae8fd544f8f6d14f60850d2300e3fa264) and [993d11e](https://github.com/cloudberrydb/cloudberrydb/commit/993d11ecc0a81b09977fc91e06302b0f5851923a)) together. Hi, many...
Applied all review comments as suggested
> hm... it seems that `make` is broken (for me) after this patch... > > ``` > > [cloudberry 8/8] RUN locale-gen en_US.utf8 \ > && ./configure --with-perl --with-python --with-libxml...
> hm... it seems that `make` is broken (for me) after this patch... > > ``` > > [cloudberry 8/8] RUN locale-gen en_US.utf8 \ > && ./configure --with-perl --with-python --with-libxml...
This change is pure interface substitution, no other features/regression added. There are still some more patch needed to make Yezzey work fine with CBDB, but I considered to split there...