react-email
react-email copied to clipboard
Inconsistant Button props and CSS properties
Hi! First of all, I really loved the project and I want to congratulate you for your work. I was reading the docs and code to undestand how you transform the "normal" css to all the compatible props and tags and I notice that you have pX and pY props that you then transform into padding css prop. Initially I thought that it was an "shortcut" bc is really common but then I saw you only use this value for textRaise so if I used styles.padding instead of pX and pY the result would be diferent
Hi @LucasAlda. Yes, thanks for opening this issue. To create padding on components for emails we can't relay on actual padding
styles (Yahoo email doesn't support box-sizing IIRC). One way of doing that is to use textRaise
syntax. Maybe instead of getting values from pY
and pX
we could grab the values from the actual styles.padding
and use those values for the textRaise
. We didn't land on a defined solution yet, so any thoughts on this would help a lot.
Sorry I didn't answer before, I undeestand the issue (Some email clients need to desapear from the internet xd) and I agree the way to do this is by using the styles.padding
values to define textRaise
.
Sounds good, @LucasAlda. Can we close this issue then?
Yeah, When I come back from vacations I will open a PR with this change.
Closing due to inactivity.