react-email
react-email copied to clipboard
Tooltip content text is invisible
Describe the Bug
Which package is affected (leave empty if unsure)
react-email
Link to the code that reproduces this issue
https://demo.react.email/preview/notifications/github-access-token?view=source
To Reproduce
https://demo.react.email/preview/notifications/github-access-token?view=source
Expected Behavior
Tooltip content text is visible
What's your node version? (if relevant)
No response
Seems ok for me, the tooltip seems to appear fine
@gabrielmfern looked into some details, this bug looks like it is related to os theme, further information:
os info
windows 10 chrome version(121.0.6167.189)
windows light theme:
windows dark theme(which looks fine):
Looks like the text color should be set to white anyways, hope it helps.
is the bug still exists? Shall I give it a try?
is the bug still exists? Shall I give it a try?
Yup it's still there. PR's are welcome! Would love to review yours if you do make one. You also don't have to ask permission to open one either. :)
On Mac OS is the same, depends on the system theme.
is the bug still exists? Shall I give it a try?
Yup it's still there. PR's are welcome! Would love to review yours if you do make one. You also don't have to ask permission to open one either. :)
Please assign this to me.
Hello, it's my first time commenting on a issue. but I'd like to add something. I think the issue in here
<TooltipPrimitive.Content {...props} className={cn( 'bg-black border border-slate-6 z-20 px-3 py-2 rounded-md text-xs', '${inter.variable} font-sans', )} ref={forwardedRef} sideOffset={sideOffset} > {children} </TooltipPrimitive.Content>
instead of giving bg-black
we can set the color based on the theme. I haven't explored the entire code so I'm not sure what is being used for themes, but maybe use external package and conditionally change the bg color, for eg dark:bg-black
for dark mode and default bg-white
. Forgive me if I'm commenting anything wrong
@gabrielmfern Hey, I've checked and the issue is still present, can you please assign it to me?