react-email icon indicating copy to clipboard operation
react-email copied to clipboard

Published 20 hours ago • verified publisher icon resendlabs

feat(render): Substitute implementation of `render` with the one from `renderAsync`

Open gabrielmfern opened this issue 1 year ago • 6 comments

This deprecates renderAsync and replaces the implementation of render with the implementation from renderAsync. Along with this implementation change of render, I also added the unit tests from renderAsync to render.

Since many of our tests use the render utility, I had to change them all to make sure that the render's returned Promise is now treated correctly.

I believe this is the best course of action for a couple of reasons that I go in depth on #1144.

Issues that this can help fix

  • #1080
  • #1029
  • #977

gabrielmfern avatar Jan 30 '24 12:01 gabrielmfern

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 4:01pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 4:01pm

vercel[bot] avatar Jan 30 '24 12:01 vercel[bot]

does this mean the react-email preview page would support async components? (RSC) that would be great!

antoinerousseau avatar Jan 30 '24 15:01 antoinerousseau

@antoinerousseau That'd be pretty cool and I'll still experiment with that but no, not yet, mostly it would be possible to have something like react-query.

gabrielmfern avatar Jan 30 '24 18:01 gabrielmfern

Hello @gabrielmfern thank you for this amazing work. Does your PR includes the ReadableByteStreamController with Safari ?

edeuxk avatar Feb 05 '24 15:02 edeuxk

Does your PR includes the ReadableByteStreamController with Safari ?

@edeuxk I don't think so. Could you link some resources? I've never heard of that

gabrielmfern avatar Feb 05 '24 16:02 gabrielmfern

Does your PR includes the ReadableByteStreamController with Safari ?

@edeuxk I don't think so. Could you link some resources? I've never heard of that

Hi @gabrielmfern we mentioned it in this issue https://github.com/resend/react-email/issues/1080#issuecomment-1855402967

RomainGueffier avatar May 23 '24 13:05 RomainGueffier

Hello, I was waiting for this PR to be resolved since it would have allowed (if I understood correctly), the upgrade to the latest Tailwind version.

Is there a particular reason for this closing ? Will any Tailwind version past 3.3.2 be supported in the near future ?

Regards.

theosenoussaoui avatar Sep 01 '24 20:09 theosenoussaoui