webofneeds icon indicating copy to clipboard operation
webofneeds copied to clipboard

Too many createWonMessage methods

Open sigpie opened this issue 5 years ago • 1 comments

Describe the issue Most actions in won-bot have a private or protected createWonMessage method. Additionally, there is a deprecated createWonMessage method in BotActionUtils. Instead of around 30 separate private methods, there should be a single utility method available to all bot actions.

This is currently not a bug, but may lead to unexpected behaviour if one or more methods are not updated in the future. Additionally, the code is harder to parse as many of these methods feature slightly different signatures.

sigpie avatar Dec 16 '19 14:12 sigpie

removed the good first issue label, this is def. not for anybody who starts contributing to our repo... refactoring this will make people gouge their eyes out...

quasarchimaere avatar Feb 11 '20 08:02 quasarchimaere