gradle-release icon indicating copy to clipboard operation
gradle-release copied to clipboard

Use project.version instead of tagName for commit messages of version change commits

Open kristofpeto-tesco opened this issue 5 years ago • 9 comments

Specifying the tagTemplate should not influence the commit message of the commits that change the project version during the release process.

kristofpeto-tesco avatar Jun 10 '20 17:06 kristofpeto-tesco

Hey @kristofpeto-tesco,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: bcd5e5e0-ab41-11ea-b056-2f6ef3b381c7

TravisBuddy avatar Jun 10 '20 17:06 TravisBuddy

Hey @kristofpeto-tesco,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 8b794d90-ab44-11ea-b056-2f6ef3b381c7

TravisBuddy avatar Jun 10 '20 18:06 TravisBuddy

Hey @kristofpeto-tesco,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 2af4b790-ab47-11ea-b056-2f6ef3b381c7

TravisBuddy avatar Jun 10 '20 18:06 TravisBuddy

@WtfJoke can you please take a look at this?

kristofpeto-tesco avatar Jun 12 '20 08:06 kristofpeto-tesco

@kristofpeto-tesco Im not a maintainer of this project. 😅

Have a little bit patience, #327 took 4 months in order to get merged ;)

WtfJoke avatar Jun 13 '20 16:06 WtfJoke

@Hillkorn, can you please take a look at this PR, it is quite a small change and is straightforward I believe.

kristofpeto-tesco avatar Jun 13 '20 17:06 kristofpeto-tesco

@Hillkorn , kind reminder, can you please review this PR? :)

kristofpeto-tesco avatar Jun 24 '20 06:06 kristofpeto-tesco

Hey Thanks for the PR and sorry that is takes that long :/

I think if we want to change this we should have a configurable template with the behavior as a default here instead of changing it to the project version. I prefer the tagName() because if you have a multi project setup and use the project name in your tag to make it unique you will have it in the commit message too.

Hillkorn avatar Jun 25 '20 06:06 Hillkorn

@kristofpeto-tesco Sorry, but @Hillkorn is absolutely right. Default tagName already does what you want to achieve. I think this PR should be closed.

rixy87 avatar Sep 30 '22 11:09 rixy87