rescript-chakra icon indicating copy to clipboard operation
rescript-chakra copied to clipboard

Add bindings for Tag Component

Open fzn0x opened this issue 2 years ago • 8 comments

Description

Add bindings for Tag, TagCloseButton, TagLabel, TagLeftIcon, and TabRightIcon.

Tasks

  • [x] Add bindings for Tag
  • [x] Add bindings for TagCloseButton
  • [x] Add bindings for TagLabel
  • [x] Add bindings for TagLeftIcon
  • [x] Add bindings for TabRightIcon

fzn0x avatar Aug 02 '21 10:08 fzn0x

Someone is attempting to deploy a commit to a Personal Account owned by @ri7nz on Vercel.

@ri7nz first needs to authorize it.

vercel[bot] avatar Aug 02 '21 10:08 vercel[bot]

Follow like avatar https://github.com/ri7nz/rescript-chakra/blob/next/src/Components/Chakra__Avatar.res#L16

So, you can add new Sub-Module like https://github.com/ri7nz/rescript-chakra/blob/next/src/Interfaces/Chakra__Theme.res#L70-L81 for define type size

Oh i see, thanks!

fzn0x avatar Aug 02 '21 12:08 fzn0x

~sizes change to ~size

Solved by 5866c968fa99e8c29e17c6185ba65c28eb6daf74 commit with adding new tag module in size module

fzn0x avatar Aug 02 '21 12:08 fzn0x

Thank you for work @fncolon but we need discussion for another component like TagLeftIcon, in TagLeftIcon have a props called as with value component.

Original example

<HStack spacing={4}>
  {["sm", "md", "lg"].map((size) => (
    <Tag size={size} key={size} variant="outline" colorScheme="blue">
      <TagLabel>Blue</TagLabel>
      <TagRightIcon as={MdSettings} />
    </Tag>
  ))}
</HStack>

I need more find something to resolve how to make binding for this case

Some reference if you want to read an article about First-Class module (may be we can solve with this approach) https://alexfedoseev.com/blog/dev/2020/cool-things-you-can-do-with-first-class-modules-in-rescript-react

r17x avatar Aug 03 '21 07:08 r17x

@fncolon please make it up to date and run script for fix eventtype thank you

r17x avatar Aug 10 '21 04:08 r17x

@fncolon please make it up to date and run script for fix eventtype thank you

Thanks, will work on it today or tomorrow

fzn0x avatar Aug 10 '21 19:08 fzn0x

can you rebase for this lot update @fncolon ?

Thanks

r17x avatar Oct 03 '21 02:10 r17x

can you rebase for this lot update @fncolon ?

Thanks

Already @ri7nz, thanks

fzn0x avatar Oct 03 '21 19:10 fzn0x