syntax icon indicating copy to clipboard operation
syntax copied to clipboard

Update default printer width to 80

Open amiralies opened this issue 4 years ago • 5 comments

from scalafmt docs about printer width:

- Keep in mind that 80 characters fit perfectly on a split laptop screen with regular resolution.
- GitHub mobile view only shows 80 characters and sometimes you might review code on your phone.

I don't have a strong opinion about width but split view is very important imo. Prettier 's default width is also 80 which is very popular in js community.

I'm also okay with making it configurable (80 / 100 / 120) without touching default width.

amiralies avatar May 25 '21 15:05 amiralies

For what it's worth, the longer line width makes reviewing the transition from production Reason to Rescript a large pain. Transitioning would be much easier with an 80 char option, even if the default remains 120.

pckilgore avatar May 25 '21 17:05 pckilgore

Any idea? I would happily work on this? /cc @IwanKaramazow @bobzhang

amiralies avatar Jun 05 '21 18:06 amiralies

We still haven't decided what we're going to do here. Exploring a completely new printer architecture atm that operates independent of the line width.

IwanKaramazow avatar Jun 05 '21 19:06 IwanKaramazow

Thank you for the answer! looking forward

amiralies avatar Jun 05 '21 19:06 amiralies

any update on this? I would be happy to help

amiralies avatar Dec 11 '21 16:12 amiralies

The rescript-lang/syntax repo is obsolete and will be archived soon. If this issue is still relevant, please reopen in the compiler repo (https://github.com/rescript-lang/rescript-compiler) or comment here to ask for it to be moved. Thank you for your contributions.

stale[bot] avatar May 28 '23 19:05 stale[bot]