rescript-vscode icon indicating copy to clipboard operation
rescript-vscode copied to clipboard

Implement our own JSON schema validation to use the correct build-schema.json for the installed compiler version

Open fhammerschmidt opened this issue 3 months ago • 9 comments

Fixes #1110

fhammerschmidt avatar Sep 25 '25 15:09 fhammerschmidt

will try a different approach (the same as TS LSP)

fhammerschmidt avatar Sep 26 '25 08:09 fhammerschmidt

@codex review

cknitt avatar Sep 30 '25 08:09 cknitt

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

image

Can we scope this to node we are currently in? I'm getting autocomplete for everything top level now, I need to see the jsx specific things that are not yet used.

nojaf avatar Oct 01 '25 08:10 nojaf

@nojaf feel free to test again.

fhammerschmidt avatar Oct 02 '25 15:10 fhammerschmidt

@codex review

cknitt avatar Oct 03 '25 06:10 cknitt

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

I still see this thing first try: image

Inside empty quotes, the completion of editor adds an additional quote: image

nojaf avatar Oct 03 '25 06:10 nojaf

Of course it only works in the jsx property and not in the more advanced cases, adding proper tests now.

fhammerschmidt avatar Oct 03 '25 13:10 fhammerschmidt