rescript-vscode icon indicating copy to clipboard operation
rescript-vscode copied to clipboard

Enable incremental typechecking by default

Open zth opened this issue 1 year ago • 4 comments

Enables incremental typechecking by default by changing the name of the prop (so old configs are invalidated) and setting a new default.

I'm sure there are more things we could do with incremental typechecking to make it a better experience, but at this point it's such a magnitudes better experience even with the small issues it might have. Enabling by default will make the experience better for everyone by default, and if issues surface we can fix them.

This also enables the projectConfig cache options, that dramatically reduce latency in certain scenarios.

zth avatar Oct 24 '24 07:10 zth

Actually, let's enable project cache config too by default. Updating the PR.

zth avatar Oct 24 '24 07:10 zth

I never tested the project cache config apparently. Is it stable enough to activate by default already?

fhammerschmidt avatar Oct 24 '24 08:10 fhammerschmidt

I think so. But it'd be good to give it a spin in your project(s) too of course.

zth avatar Oct 24 '24 08:10 zth

I mean that's why we have pre-releases anyway, right? Or do you want to release this as stable soon?

fhammerschmidt avatar Oct 24 '24 08:10 fhammerschmidt

We can do pre-release for a while, sure. Maybe a week or so. But then the big benefit comes from shipping this to stable.

zth avatar Oct 24 '24 11:10 zth