rescript-vscode icon indicating copy to clipboard operation
rescript-vscode copied to clipboard
verified publisher icon rescript-lang

Using "rename symbol" on labelled argument breaks

Open JonoPrest opened this issue 1 year ago • 3 comments

When renaming a labelled arg, if you include the ~ it propogates to the renamed locations. If you remove it then it does not stay a labelled argument.

https://github.com/rescript-lang/rescript-vscode/assets/65739024/2486d2b2-0b05-49ff-b290-4710b48710a7

JonoPrest avatar Jun 04 '24 08:06 JonoPrest

Yeah, this is known and unfortunately a little bit difficult to fix. Some WIP prior art: https://github.com/rescript-lang/rescript-vscode/pull/872

zth avatar Jun 04 '24 08:06 zth

Yeah, this is known and unfortunately a little bit difficult to fix. Some WIP prior art: #872

Ah ok cool 👍🏼 not a big issue just thought I would flag if nobody else noticed.

JonoPrest avatar Jun 04 '24 08:06 JonoPrest

Yeah, we definitely want it fixed, so it's great that you report it 👍

zth avatar Jun 04 '24 08:06 zth