rescript-compiler icon indicating copy to clipboard operation
rescript-compiler copied to clipboard

Should use `in` for optional fields check

Open DZakh opened this issue 10 months ago • 4 comments

https://rescript-lang.org/try?version=v12.0.0-alpha.9&module=esmodule&code=C4TwDgpgBAhlC8UDeAzA9mg-ALigVwDsBLYAXwChyAbCYKdNBWBAPnKigGcB3EgYwAWzJOygAfZA1wB9UqygBGUROnyATKIpA

DZakh avatar Feb 22 '25 18:02 DZakh

Here's the first part https://github.com/rescript-lang/rescript/pull/7342

DZakh avatar Mar 14 '25 08:03 DZakh

https://github.com/rescript-lang/rescript/pull/7342#issuecomment-2732403931

@DZakh Can we close this issue? or do you want to open this for further record enhancement too?

cometkim avatar Apr 10 '25 17:04 cometkim

No, the issue is not solved yet. It requires the record changes we talked about.

DZakh avatar Apr 10 '25 18:04 DZakh

But that doesn't relate to in operator, right? Can you change the issue description or separate it?

cometkim avatar Apr 10 '25 18:04 cometkim