rescript-compiler icon indicating copy to clipboard operation
rescript-compiler copied to clipboard
verified publisher icon rescript-lang

Test emitting let instead of var.

Open cristianoc opened this issue 3 years ago • 4 comments

Fixes https://github.com/rescript-lang/rescript-compiler/issues/856

  • Need to check that no cases are missed where this could introduce regressions even if the tests appear to be passing

  • This will generate a huge amount of noise in the diff w.r.t. other versions of the compiler. It might not be ideal to have this change in an initial version of compiler v11 if other changes are important as they would get lost in the noise

  • Note that the transformation creating problems in https://github.com/rescript-lang/rescript-compiler/pull/6479 can be removed

cristianoc avatar Mar 30 '23 08:03 cristianoc

You can then remove the previous fix (using IIFE) used to capture mutable variable

hhugo avatar Apr 03 '23 15:04 hhugo

I wonder how much it'll affect performance. But probably it won't be a big difference.

DZakh avatar Nov 09 '23 09:11 DZakh

@DZakh did you see this: https://github.com/rescript-lang/rescript-compiler/issues/856#issuecomment-1483755503 ?

fhammerschmidt avatar Nov 09 '23 09:11 fhammerschmidt

Wow, cool

DZakh avatar Nov 09 '23 09:11 DZakh

@cristianoc Could you rebase this? Now that 11.1 is out and development focus is shifting to v12, it would be great to get this merged.

cknitt avatar Apr 27 '24 18:04 cknitt

Sorry, I'm afraid you'll also need to rebase again.

cknitt avatar Apr 29 '24 07:04 cknitt

@cknitt ready to go

cristianoc avatar Apr 30 '24 08:04 cristianoc