`bisect_ppx` broken on `10.0.0-rc.1`

[quinn-dougherty]

We use bisect_ppx for coverage reports on our monorepo.

Observe this job in CI (running on ubuntu) for a real-world scenario.

For a minimal reproducer, you can clone git clone [email protected]:aantron/bisect-starter-rescript.git and change the rescript version value in package.json to 10.0.0-rc.1.

Thank you for filing! Check list:

• [x] Is it a bug? Usage questions should often be asked in the forum instead.
• [x] Concise, focused, friendly issue title & description.
• [x] A minimal, reproducible example.
• [x] OS and browser versions, if relevant.
• [ ] Is it already fixed in master?

[cristianoc]

Did you check the release notes? Some parts of Pervasives, to do with printf etc, have been removed. This should not affect a ppx in any way, so I guess what we're seeing are just some test files that are compiled, and contain uses of Pervasives that are no longer supported.

[quinn-dougherty]

Error message doesn't mention Pervasive.

FAILED: src/common/bisect_common-Bisect.cmi
File "/home/qd/.../bisect-starter-rescript/node_modules/bisect_ppx/src/common/bisect_common.mli", line 68, characters 42-53:
Error: Unbound type constructor out_channel
FAILED: cannot make progress due to previous errors.
Failure: /home/qd/.../bisect-starter-rescript/node_modules/rescript/linux/ninja.exe     
Location: /home/qd/.../bisect-starter-rescript/node_modules/bisect_ppx/lib/bs
 error Command failed with exit code 1.

Same error message on BISECT_ENABLE=true yarn build

No mention of Pervasive in release notes.

[cristianoc]

Feel free to suggest improvements to the changelog in https://github.com/rescript-lang/rescript-compiler/blob/10.0_release/CHANGELOG.md#boom-breaking-change-2

There, only some printing functions are mentioned (no mention of types such as out_channel).

This issue should be moved to the bisect ppx project, so that it does not try to use out_channel with rescript.

[aantron]

Bisect now supports ReScript 10. This can be closed.

[zth]

@aantron thank you!