Clean up strings in the compiler toolchain
See https://github.com/rescript-lang/rescript-compiler/issues/5521 and https://github.com/rescript-lang/syntax/pull/602
Just writing down some notes here.
This reliance on indirect type checking by putting "" at either end of string concatenation seems brittle.
Also there seem to be several layers of sediment left presumably from old ways of doing things.
So `stuff` is the same as js`stuff` by convention I think.
Then there is j`stuff` which somehow obeys different rules. So in j`$x` the $x actually has a meaning. And x does not need to be a string. The consequence of this is that "" + x is not the same as x when x is not a string. So removing empty string concatenation in the back-end of the compiler is also delicate as it's easy to do it wrong (3 + "" can't be removed).
Then there's json`stuff` which I don't know maybe it's the same as j but old, not really sure. Are they really treated in the same way at every stage in the compiler? Not sure.
All this is represented internally by putting together strings that have a tag "j" or "js" or "json".
In addition to all that, strings produced by the parser are now by default unicode, and that uses the tag "*j". But, there's also the OCaml parser for .ml files which will never generate "*j" for normal strings.
In addition to all this, there's some half attempt to also use a type "unicode" inside the back-end of the compiler, which seems incomplete.
Also, there's a quoting mechanism that happens on dump (code generation) which depends on which kind of string it is.
Goes without saying, all this needs a good cleanup.
How to debug:
./darwinarm64/bsc.exe -dparsetree templ.res
Gives the parse tree coming from the parser (which produces js string) and the front-end https://github.com/rescript-lang/rescript-compiler/blob/master/jscomp/frontend/ast_utf8_string_interp.ml#L391
Then the back-end is executed and the code generated.
One issue is that the behaviour of string templates is not specified, so it's not clear what to expect.
What is `foo` and j`foo` and js`foo` and json`foo` ? Do we need all of them? How do they differ?
CC @bobzhang
https://github.com/rescript-lang/rescript-compiler/pull/5641
After https://github.com/rescript-lang/rescript-compiler/pull/5642, the list of delimiters currently used is explicit:
and delim = | DNone | DJ | DJS | DStarJ | DJson
jsonis only used with@ase.g. https://github.com/rescript-association/rescript-lang.org/issues/550jsis the same as omitting it, i.e. language-level string interpolationjis old interpolation with different rules, e.g.$ainstead of${a}andadoes not have to be string, there are probably still uses*jis for internal use
https://github.com/rescript-lang/rescript-compiler/pull/5645
Not clean, but cleaner now.