rescript-compiler Make color output configurable

seems powershell can not recognize. need check cmd.exe

Mar 11 '17 21:03 bobzhang

Did the "building foo" part in the ninja file fail? I'm only piggy backing on ninja's logic for outputting colors or not. Unless the ansi code themselves are bad.

Mar 13 '17 21:03 chenglou

it did not fail, just the output is not recognized by powershell

[email protected] At: 03/13/17 17:21:48" data-digest="From: [email protected] At: 03/13/17 17:21:48" style=""> From: [email protected] At: 03/13/17 17:21:48 To: [email protected] Cc: HONGBO ZHANG (BLOOMBERG/ 731 LEX), [email protected] Subject: Re: [bloomberg/bucklescript] disable color output for Win (#1350)

Did the "building foo" part in the ninja file fail? I'm only piggy backing on ninja's logic for outputting colors or not. Unless the ansi code themselves are bad.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Mar 13 '17 21:03 bobzhang

For note, iex works fine in powershell with colors and all, and powershell itself is a very colorful shell in general, so what of the output is not getting recognized even as the BEAM works with it fine?

Mar 14 '17 14:03 OvermindDL1

Last time I saw the power shell output of my colleague, it displayed some raw escaped code, do u see a colorful output on your powershell? Nothing to blame on powershell, just we don't have expertise on it, your contributions or feedback is appreciated 😊

----- Original Message ----- From: OvermindDL1 [email protected] To: [email protected] CC: HONGBO ZHANG, [email protected] At: 14-Mar-2017 10:25:27

For note, iex works fine in powershell with colors and all, and powershell itself is a very colorful shell in general, so what of the output is not getting recognized even as the BEAM works with it fine?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Mar 14 '17 15:03 bobzhang

I know for Rust and Elixir color is fine in powershell. :-)

Let me try compiling some bucklescript right quick by running powershell from the start menu directly, and yeah, I'm getting colored output in powershell just fine:

EDIT: I am on Windows 10 though, so maybe a difference there?

Mar 14 '17 18:03 OvermindDL1

Yeah, might be, he used win 7

Mar 14 '17 18:03 bobzhang

Yeah, might be, he used win 7

That would be it, the default console on Windows 10 was significantly improved over prior versions, I bet that is one way.

Mar 14 '17 21:03 OvermindDL1

note we will not disable it on windows, but make it configurable for poor windows 7 users

Mar 15 '17 13:03 bobzhang

It seems like this would be useful for CI as well.

Nov 25 '21 18:11 kevinbarabash

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Mar 13 '24 08:03 stale[bot]