bucklescript-addons icon indicating copy to clipboard operation
bucklescript-addons copied to clipboard

Updated bs-mocha

Open Risto-Stevcev opened this issue 8 years ago • 3 comments

I updated bs-mocha

  • I updated to the latest version of mocha and bs-platform
  • I added missing definitions to the interface file (those functions otherwise couldn't be reached without it)
  • I removed the [@bs] annotations, they seemed to be unnecessary since the bindings worked fine without it (I think unit -> unit works the same curried/uncurried because it's unary)

@bobzhang One other thing that I had to do in order to use these bindings is to copy the bsconfig.json from the bucklescript-addons/bindings/bs-mocha folder to my project's node_modules/bs-mocha folder. For some reason all files are there when I install bs-mocha (using npm install bs-mocha) except for bsconfig.json, so bsb never found it. I don't know what's hiding it, I think this is the only thing left to do

Risto-Stevcev avatar Dec 19 '17 15:12 Risto-Stevcev

@Risto-Stevcev would you take it over to move it to https://github.com/reasonml-community/ ?

bobzhang avatar Dec 20 '17 09:12 bobzhang

@bobzhang Sure, I'm not sure how to take it over and move it there though. I'm not a member

Risto-Stevcev avatar Dec 20 '17 15:12 Risto-Stevcev

@Risto-Stevcev I've created https://github.com/reasonml-community/bs-mocha and made you an admin on it. Let me know if you need help moving the code there.

@bobzhang Can you give Risto publishing rights for bs-mocha on npm?

glennsl avatar Jan 22 '18 20:01 glennsl