add DocSearch v3

[aspeddro]

Changes

• Add bindings to @docsearch/react v3

UI Changes

• Search icon is now visible in any width. Before, it was not visible between 599px and 766px

• Remove the search icon from the mobile menu and keep it always visible. This is the behavior on sites like reactnative.dev, tailwindcss, and reactjs

• [x] Update record extractor

  • See indexing content for faceting #245

Fix #498 Fix #528 Fix #245 Fix #465

[ryyppy]

Thanks for the PR.

So generally this looks good, although I am not entirely convinced about algolia's way of design here and at some point I wanted to have something custom tailored. Anyways, the only nitpick: This doesn't really fix #465 since we'd need to fix the Algolia crawling and UI mapping first (as stated in your TODO section). The new experience is even more confusing, since it will render empty rows.

Still wondering if we should merge this and then follow up with the relevant index changes.

[aspeddro]

So generally this looks good, although I am not entirely convinced about algolia's way of design here and at some point I wanted to have something custom tailored.

Okay, I'll refactor it.

This doesn't really fix https://github.com/rescript-association/rescript-lang.org/issues/465 since we'd need to fix the Algolia crawling and UI mapping first (as stated in your TODO section).

Sure, Fixed.

The new experience is even more confusing, since it will render empty rows.

This is due to the new version of the extractor, which must be updated.

[aspeddro]

Still wondering if we should merge this and then follow up with the relevant index changes.

Is it possible to create a new extractor so that we can test it?

[ryyppy]

I have access to the new editor experience on the algolia website. Will need to update the api keys and then try to work my way around the crawling configuration. Will let you know as soon as I got something going.

[aspeddro]

Now the design is more personalized. I changed it to the DocSearchModal component.

[aspeddro]

https://github.com/rescript-association/rescript-lang.org/pull/534/commits/2e22535d68710a1b265ca0e8cededaa32a017b7b add an alternative to not rendering empty lines.

[aspeddro]

I don't think we need to change the crawler. Git tags are displayed.

[ryyppy]

can we only show results for the latest version? We may make this dependent on the current version that is being browsed, but for the start, only latest would be great.

[vercel[bot]]

@aspeddro is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

[aspeddro]

Ready for review

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rescript-lang.org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2024 7:43am