rescript-lang.org icon indicating copy to clipboard operation
rescript-lang.org copied to clipboard

refactor: simplify sidebarlayout and removed nested divs

Open jderochervlk opened this issue 3 weeks ago • 9 comments

There were a lot of extra divs leading to some layout wonkiness at different screen sizes.

Before

image

After

image

jderochervlk avatar Dec 01 '25 14:12 jderochervlk

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: af23177
Status: ✅  Deploy successful!
Preview URL: https://634efa5f.rescript-lang.pages.dev
Branch Preview URL: https://vlk-fix-sidebarlayout-overfl.rescript-lang.pages.dev

View logs

Hmmm, is the smaller left padding deliberate?

fhammerschmidt avatar Dec 01 '25 14:12 fhammerschmidt

Hmmm, is the smaller left padding deliberate?

Nope, I have a few things to cleanup.

jderochervlk avatar Dec 01 '25 14:12 jderochervlk

Hmmm, is the smaller left padding deliberate?

Fixed.

jderochervlk avatar Dec 01 '25 15:12 jderochervlk

Ah so you wanted to put the sidebar actually on the side now? Regardless, the content ist left-aligned as well now, not sure that is an improvement.

fhammerschmidt avatar Dec 01 '25 15:12 fhammerschmidt

Ah so you wanted to put the sidebar actually on the side now? Regardless, the content ist left-aligned as well now, not sure that is an improvement.

Moving it to the side wasn't intended. I was simplifying some of the divs to address content overflowing at different break points. It shouldn't look too different from prod right now.

jderochervlk avatar Dec 01 '25 15:12 jderochervlk

image

Almost! Text needs some padding on the left.

fhammerschmidt avatar Dec 02 '25 09:12 fhammerschmidt

image

Almost! Text needs some padding on the left.

Done! I also made some padding tweaks for smaller screens to remove some of the extra whitespace on tablets and large phones.

jderochervlk avatar Dec 02 '25 16:12 jderochervlk

I now have this weird glitch image

fhammerschmidt avatar Dec 02 '25 16:12 fhammerschmidt