rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Use `jiff` date-time crate

Open NiharP31 opened this issue 9 months ago • 3 comments

Related

  • Closes #9317 (Most of the migrations are done)
  • Implements TODO: Migrate from time and chrono to jiff when upgrading to pyo3 0.24

What

This PR migrates our time libraries from time and chrono to jiff, standardizing on a single time library throughout the codebase. The primary changes include:

  • Removed direct dependencies on time and chrono from Cargo.toml files
  • Added jiff as a dependency in the necessary crates
  • Migrated timestamp functionality in re_ui/notifications.rs to use jiff's API
  • Updated timestamp serialization and formatting in analytics components
  • Modified Python bindings to use jiff instead of chrono for timestamps
  • Added tests to verify the correctness of the migration

This change simplifies our dependency tree and resolves the TODO comment in the root Cargo.toml. Note that a subsequent PR will update cargo.deny rules to ban both time and chrono crates to prevent future usage.

Pending

  • Cargo.deny - Based on this feedback, I will update this file
  • ./Cargo.toml - added jiff version; I haven't erased chrono/time original dependencies
  • web-time - Needs confirmation if this needs migration or not

NiharP31 avatar Apr 08 '25 00:04 NiharP31

@Wumpf. I've migrated files from time and chrono to jiff. I added comments at the end of PR. Can you check them and let me know if any improvements are needed.

NiharP31 avatar Apr 08 '25 00:04 NiharP31

Is this blocked by something? Do you need help getting it finnished?

emilk avatar Apr 24 '25 12:04 emilk

@emilk, recovered from health issues. Just need to sort the wasm js. Will push it soon

NiharP31 avatar Apr 24 '25 16:04 NiharP31

@NiharP31 hope your recovery continued well! Are you still interesting in finishing this up or should someone else take over?

Wumpf avatar Jun 16 '25 08:06 Wumpf

Seems abandoned. I'll look into wrapping it up

Wumpf avatar Aug 06 '25 07:08 Wumpf