rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Missing `opened_application/recording_id` in external data loader example

Open EtaLoop opened this issue 1 year ago • 0 comments

I tried to log data using an external data loader, with log_file_from_path and I got en error.

So I tried to test the loader for rust files (https://github.com/rerun-io/rerun/tree/main/examples/rust/external_data_loader) and I got the same error :

ERROR re_data_loader::loader_external] Failed to execute external loader filepath="file.rs" loader="rerun/target/release/rerun-loader-rust-file" reason=Unrecognized argument: --opened-application-id

With this code :

rec = rr.new_recording(application_id="My window", recording_id="My rec", spawn=True)
rr.log_file_from_path(file_path="file.rs", recording=rec.to_native())

So I add opened_application_id and opened_recording_id to https://github.com/rerun-io/rerun/blob/1ad3042a85622804a6923a5d0c65f82ba1e601d3/examples/rust/external_data_loader/src/main.rs#L28

Now this works.

EtaLoop avatar Nov 20 '24 12:11 EtaLoop