rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Add Undo/Redo support in the viewer

Open emilk opened this issue 1 year ago • 2 comments

What

  • Closes https://github.com/rerun-io/rerun/issues/3135
  • Proceeded by https://github.com/rerun-io/rerun/pull/7602
  • Proceeded by https://github.com/rerun-io/rerun/pull/7603
  • Proceeded by https://github.com/rerun-io/rerun/pull/8241
  • New issue: https://github.com/rerun-io/rerun/issues/8249

This PR implements Undo and Redo for any edit to the active blueprint.

https://github.com/user-attachments/assets/05018729-f01e-42f4-a84f-b48dbf31b060

Implementation

This implements undo/redo by editing the "time cursor" for the blueprint timeline. Undo moves it backwards, redo forwards. When doing an action, all redo history is erased from the store with a new ChunkStore::drop_time_range function.

Known shortcomings

  • Undo doesn't work when the blueprint streams panel is open

Checklist

  • [x] I have read and agree to Contributor Guide and the Code of Conduct
  • [x] I've included a screenshot or gif (if applicable)
  • [x] I have tested the web demo (if applicable):
  • [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • [x] If applicable, add a new check to the release checklist!
  • [x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

emilk avatar Sep 29 '24 15:09 emilk

This is blocked by:

  • https://github.com/rerun-io/rerun/issues/8056

emilk avatar Nov 11 '24 09:11 emilk

Web viewer built successfully. If applicable, you should also test it:

  • [ ] I have tested the web viewer
Result Commit Link
2e6be76 https://rerun.io/viewer/pr/7546

Note: This comment is updated whenever you push a commit.

github-actions[bot] avatar Nov 28 '24 16:11 github-actions[bot]