rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Allow color specification on `Asset3D`

Open EtaLoop opened this issue 1 year ago • 1 comments

What

The idea is to reproduce behavior of Mesh3D regarding color modification on Asset3D :

  • add albedo_factor
  • add vertex_colors as in Mesh3D

In order to overwrite white default texture of Asset3D loaded from stl and obj (gltf already have albedo_factor in file).

See: #5253

Screenshot from 2024-09-18 16-05-54

Checklist

  • [x] I have read and agree to Contributor Guide and the Code of Conduct
  • [x] I've included a screenshot or gif (if applicable)
  • [ ] I have tested the web demo (if applicable):
  • [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • [ ] If applicable, add a new check to the release checklist!
  • [x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

EtaLoop avatar Sep 20 '24 13:09 EtaLoop

let me know when you think this is ready for review again! :) (or use the little "re-request review" button so this shows up in my review queue again)

Wumpf avatar Oct 03 '24 12:10 Wumpf

Now that https://github.com/rerun-io/rerun/pull/7824 is in, it should be a lot more straight forward to do this!

Wumpf avatar Oct 22 '24 13:10 Wumpf

Thanks a lot :+1:

EtaLoop avatar Oct 22 '24 13:10 EtaLoop

I wanted to push a fix for the doc issues ci brought up, but I don't have permissions it seems (hum, this usually works, no idea why) That's my fix, can you cherrypick it in? https://github.com/rerun-io/rerun/commit/5c7bea0e7b817cd4abdaaebb74005f533920230a

Wumpf avatar Oct 23 '24 13:10 Wumpf

Done, sorry for the mess up there :sweat:

EtaLoop avatar Oct 24 '24 07:10 EtaLoop

Thank you for your time and advice

EtaLoop avatar Oct 24 '24 09:10 EtaLoop