rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Do not crop tensor axes to the area where the tensor is visible

Open teh-cmc opened this issue 1 year ago • 4 comments

edit: the axis label is cropped to the area where the tensor is actually visible, which leads to unexpected visual glitches for very thin tensors.

Image

Data disappears and reappears as you hover it or resize the viewer.

https://github.com/rerun-io/rerun/assets/2910679/c708cada-4512-4a6b-bddc-5279780d0c10

teh-cmc avatar Jul 01 '24 14:07 teh-cmc

the description sounds like we're missing a redraw on changing the property, but the capture looks like much more is broken? I can see there's a 1D tensor here, but I don't get that's overdrawn there upon mouse interaction

Not unlikely that aspect ratio is broken in particular for 1D tensor

Wumpf avatar Jul 01 '24 15:07 Wumpf

100% repro:

git checkout main
pixi run -e examples py-build
pixi run -e examples python tests/python/release_checklist/check_1d_tensor_data.py

Go to the tensor view, switch the dimension mapping so that it goes vertical, see that part of the tensor is somehow missing.
The problem gets worse as your window's height grow larger.

image

teh-cmc avatar Jul 03 '24 15:07 teh-cmc

Got a very subtle repro now. Looks like this is the on-hover axis labels not fully showing image

Wumpf avatar Jul 03 '24 15:07 Wumpf

What you're seeing is basically the axis label slightly overlapping the tensor.

Image

That label disappears on hover, thus the dynamic behaviour.

The root cause is that this label is cropped to the tensor area, which doesn't make any sense.

Image

abey79 avatar Apr 23 '25 08:04 abey79