rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Further check and refactor unwrap() usage

Open Artxiom opened this issue 1 year ago • 3 comments

@Wumpf Follow up for #3408. After the initial refactor there are still some crates left which use unwrap:

  • [x] re_data_store
  • [x] re_dev_tools
  • [x] re_entity_db
  • [x] re_format_arrow
  • [x] re_log_types
  • [x] re_query
  • [ ] re_renderer
  • [ ] re_renderer_examples/*
  • [ ] re_sdk
  • [ ] re_space_view_spatial
  • [ ] re_space_view_tensor
  • [ ] re_space_view_time_series
  • [ ] re_time_panel
  • [ ] re_types_builder
  • [ ] re_types_core
  • [ ] re_viewer
  • [ ] re_viewport
  • [ ] re_ws_comms
  • [ ] snippets

They are all marked with:

// TODO(#3408): remove unwrap()
#![allow(clippy::unwrap_used)]

Artxiom avatar May 15 '24 09:05 Artxiom

Hello. I want to take this issue (I started with re-renderer)

@ilyaaay If you want to continue on this one please start with the next one (I would suggest re_sdk) because I already did something for re_renderer, only didn't have time to finish it.

Artxiom avatar Aug 02 '24 06:08 Artxiom

@ilyaaay I realized it's not a huge amount of changes yet so I pushed my branch here.

Feel free to pick it up - I will be super busy probably until beginning of next year. Just please @mention me somewhere when you do so, so I don't pick it up accidentally again.

Artxiom avatar Aug 03 '24 19:08 Artxiom

Hi everyone. I'd like to contribute to this issue and I started working on the top/re_sdk and the store/re_sdk_comms crates.

riccardocinti avatar Sep 14 '24 21:09 riccardocinti