rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Use `list_item2` for the component list in `InstancePath::data_ui`

Open abey79 opened this issue 1 year ago • 2 comments

What

  • Fixes #4161
  • Follow up to #6297
  • Follow up to #6325

This PR uses list_item2 for the component list in the entity path selection panel and tooltip.

Blocked by https://github.com/emilk/egui/issues/4471 to resolve the tooltip "first frame flicker"

TODO:

  • [ ] ⚠️ full_span_scope panic on hover on spatial space view: https://github.com/rerun-io/rerun/issues/6246

selection panel

before:

image

after:

image

Note: the hover behaviour is the biggest change here: now full span, previously just on the left-column button

tooltip

before:

image

after: image

Checklist

  • [x] I have read and agree to Contributor Guide and the Code of Conduct
  • [x] I've included a screenshot or gif (if applicable)
  • [x] I have tested the web demo (if applicable):
  • [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • [x] If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

abey79 avatar May 13 '24 16:05 abey79

before screenshots would be nice. my memory is pretty bad with these things :)

Wumpf avatar May 15 '24 08:05 Wumpf

before screenshots would be nice. my memory is pretty bad with these things :)

Done (though visually it doesn't make such a difference on screenshots)

abey79 avatar May 15 '24 08:05 abey79

Deployed docs

Commit Link
e47d6cd93aa14efd81925d02532390c3e4b843d8 https://landing-bpxphhc9m-rerun.vercel.app/docs

github-actions[bot] avatar May 20 '24 16:05 github-actions[bot]