rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Document how to run Python examples

Open emilk opened this issue 1 year ago • 3 comments

There was documentation there, but I couldn't understand it. Thankfully Jeremy told me the magic incantation, so I decided to write it down in a way that I can understand.

I decided to remove the -e examples part of it, since everything seems to work without it and because this is the docs for the examples environment says it is WIP:

https://github.com/rerun-io/rerun/blob/0ac38a4df54c45f2c34f6a75c6044f9785719615/pixi.toml#L39-L40

Checklist

  • [x] I have read and agree to Contributor Guide and the Code of Conduct
  • [x] I've included a screenshot or gif (if applicable)
  • [x] I have tested the web demo (if applicable):
  • [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • [x] If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

emilk avatar May 03 '24 15:05 emilk

Deployed docs

Commit Link
0e74ba1ffe3845c5a7482ff1af25c5bdd8e217c7 https://landing-kbqhxnndq-rerun.vercel.app/docs

github-actions[bot] avatar May 03 '24 15:05 github-actions[bot]

It seems like @abey79 convinced @jleibs that pixi shell is not the best recommendation, and that the summary should be

pixi run -e examples py-build
pixi run -e examples minimal

emilk avatar May 06 '24 05:05 emilk

It seems like @abey79 convinced @jleibs that pixi shell is not the best recommendation, and that the summary should be

pixi run -e examples py-build
pixi run -e examples minimal

To clarify, pixi shell is fine. What I find inappropriate is to advertise using pixi's default environment as a recipient to install random stuff, including examples. Our pixi.toml declares an examples environment that is made for that, and offers isolation from the other pixi environments.

So both are perfectly fine imo:

pixi run -e examples py-build
pixi run -e examples minimal

and:

pixi shell -e examples
pixi run py-build
pixi run minimal

The latter case works because pixi run recognises that one of its environment has been activated and uses it instead of default.

abey79 avatar May 06 '24 06:05 abey79

Closed by https://github.com/rerun-io/rerun/pull/6466#pullrequestreview-2089971006

emilk avatar May 31 '24 06:05 emilk