rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Python API: log and swallow all exceptions

Open emilk opened this issue 3 years ago • 5 comments

Instead of throwing errors, the logging SDK will now log errors, including call stack. This means the users code will continue to run, just with broken rerun logging.

Checklist

  • [x] I have read and agree to Contributor Guide and the Code of Conduct
  • [ ] I've included a screenshot or gif (if applicable)
  • [ ] I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

emilk avatar Dec 13 '22 20:12 emilk

This pretty much looks exactly like what I would expect.

jleibs avatar Dec 13 '22 22:12 jleibs

With this fix I continue to get type checking functionality in vs-code in python3.10. Would be great to get someone with an older python to confirm this doesn't break anything.

jleibs avatar Dec 16 '22 01:12 jleibs

No, it doesn't work for me 😭 :

Screen Shot 2022-12-16 at 10 22 26

Same on main:

Screen Shot 2022-12-16 at 14 49 37

emilk avatar Dec 16 '22 09:12 emilk

But does it crash?

I think typing_extensions makes it valid python… but doesn’t actually include the full functionality.

jleibs avatar Dec 16 '22 11:12 jleibs

But does it crash?

I think typing_extensions makes it valid python… but doesn’t actually include the full functionality.

It runs fine, but the type hinting is broken which is quite sad

emilk avatar Dec 16 '22 13:12 emilk

I'm gonna give this another go

emilk avatar Mar 02 '23 10:03 emilk

Replaced by https://github.com/rerun-io/rerun/pull/1477

emilk avatar Mar 02 '23 13:03 emilk