rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Resetting view by double clicking not working with huge amount of TimeSeriesScalar logs

Open seongs1024 opened this issue 1 year ago • 10 comments

Describe the bug

The view is not reset by double clicking when it reaches to about 40k log events (and a little bit of hanging about 5 seconds happened when I tried to brute-force multi-clicking to reset view)

Screenshots

The second view cannot be reset to the first

image image

Desktop (please complete the following information):

  • OS: macOS Catalina version 10.15.7

Rerun version

re_viewer: 0.12.1(bef0d78) wasm32-unknown-unknown rustc: 1.74.0 LLVM: 17.0.4

Additional context

seongs1024 avatar Jan 29 '24 11:01 seongs1024

Could that be to the UI become too sluggish for double-click to be properly detected?

(BTW, the next release will considerably improve the performance of timeseries).

abey79 avatar Jan 29 '24 12:01 abey79

It could be.

# Performance metrics
CPU time: 380ms
Memory: 1.2GB RAM
Latency: 1.2s
image

seongs1024 avatar Jan 29 '24 13:01 seongs1024

By the way, the memory panel consumes resources fairly a lot

seongs1024 avatar Jan 29 '24 13:01 seongs1024

Any chance you could try using a nightly build of the viewer @seongs1024 (either by building from source or through our dev builds)?

We're only a few days away from releasing 0.13, which should drastically improve the performance of timeseries. This is a perfect time to try it out and see if things work out for your use case.

teh-cmc avatar Jan 29 '24 13:01 teh-cmc

Opps.. Got this error... Need to upgrade my chrome browser though, cannot do this on my workspace...

image

If you don't mind, you can test my works https://github.com/seongs1024/labs/tree/timeseries

seongs1024 avatar Jan 29 '24 14:01 seongs1024

ah apologies, that's an intermittant issue we fixed by now, but we have to update a dependency for it (egui). Thanks for linking to your project, we'll have look!

Wumpf avatar Jan 29 '24 14:01 Wumpf

Tested on prerelease 896ffcc by changing browser Chrome to Safari!

The performance enhancement is tremendously great!

But double click resetting view is still not working...

seongs1024 avatar Jan 29 '24 14:01 seongs1024

I guess clicking issues are related when the UI becomes laggy.

Cannot click top left rerun icon to reset viewer when time goes

seongs1024 avatar Jan 29 '24 14:01 seongs1024

@seongs1024 I tried your project on the timeseries branch but wasn't able to get the browser version running - Rerun currently has trouble building the web viewer outside of its own repo and I'm now really curious how you managed to 😄 .

So I changed it to use the native viewer and there everything works (unsurprisingly) smoothly on my machine. I suppose the native viewer is not an option for you for some reason? (Its performance is generally better by a huge margin, making the application a lot more responsive)

Wumpf avatar Feb 01 '24 10:02 Wumpf

FYI, here are steps to build my own web_viewer.

  1. git clone [email protected]:seongs1024/labs.git -b timeseries
  2. cargo run --release
  3. No /re_run/web_viewer/re_viwer.js error occurs
  4. Go to the path where the compiler let you know like ${CARGO_HOME}/git/checkout/rerun-{hash}
  5. Run the script in scripts/setup_web.sh to install binaryen following the Rerun docs
  6. Build rerun by cargo build --release in ${CARGO_HOME}/git/checkout/rerun-{hash}
  7. Back to the the project directory what you cloned
  8. Finally, cargo run --release again then it will show up on your browser!

Thank you! @Wumpf

Hope WASM to be able to support multithreads someday

seongs1024 avatar Feb 01 '24 13:02 seongs1024