rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Increase image cache max size to 5 GB

Open emilk opened this issue 2 years ago • 4 comments

EDIT: I went to just 2GB.

IGNORE THIS

This is just enough to fit default colmap images in cache :)

This means that opening colmap and hitting loop will stutter first play-through, then run smooth as butter.

Here's the memory use when looping colmap:

image

Checklist

  • [x] I have read and agree to Contributor Guide and the Code of Conduct
  • [x] I've included a screenshot or gif (if applicable)
  • [ ] I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

emilk avatar Feb 14 '23 13:02 emilk

5gb seems risky to me. Especially given that we don't set a limit on vram and this will allocate more textures as well Have a poor idea about what's mainstream hardware though

Wumpf avatar Feb 14 '23 13:02 Wumpf

https://store.steampowered.com/hwsurvey/Steam-Hardware-Software-Survey-Welcome-to-Steam

VRAM: image

20% has 2GB or less 😭

Not a perfect overlap between Steam gamers and computer vision researchers though, but… point taken.

emilk avatar Feb 14 '23 14:02 emilk

I can see how much the fiat demo uses. 2GB should be fairly safe imho

emilk avatar Feb 14 '23 14:02 emilk

ok, fiat is no problem at all

emilk avatar Feb 14 '23 14:02 emilk

We need to rethink this and do it properly.

We can have a big RAM-cache of decoded JPEG images, and then a MUCH smaller VRAM cache of uploaded textures.

Issue created here:

  • https://github.com/rerun-io/rerun/issues/1462

emilk avatar Mar 01 '23 15:03 emilk